Introduce Product Resource - #39
Open
imRohan wants to merge 8 commits into
Open
Conversation
imRohan
force-pushed
the
rl-introduce-products
branch
from
May 8, 2026 18:54
b8686e4 to
e4434cf
Compare
Collaborator
Author
|
Testing, working on staging (Auth + Retrieve Product) |
imRohan
force-pushed
the
rl-introduce-products
branch
2 times, most recently
from
May 13, 2026 15:40
83e0c90 to
c99e65f
Compare
Contributor
|
the authentication changes need to be their own PR... |
jmazur
approved these changes
Jul 16, 2026
Collaborator
Author
|
This needs to be refactored after this PR is merged: #41 |
imRohan
force-pushed
the
rl-introduce-products
branch
2 times, most recently
from
August 10, 2026 18:13
ac7eff9 to
8b4e783
Compare
imRohan
force-pushed
the
rl-introduce-products
branch
3 times, most recently
from
August 12, 2026 14:31
f5022c0 to
8db3d7c
Compare
Version 2 of the api is now available, and introduces the Product resource. We'd like to expose this via the gem, allowing our clients to consume this new resource. The Product resource will be retrieved via ID using a different api, version 2. This new API utilizes a basic authentication scheme. Since this is the first resource to be consumed via the v2 API this PR not only introduces Products, it also adds all the plumbing required to interact with the new api version. This change addresses the need by: * Introducing a v2 authenticator * Introducing a v2 api * Introducing a CoreObject resource which can be used by all core (v2) objects * Introducing a Product resource
imRohan
force-pushed
the
rl-introduce-products
branch
from
August 18, 2026 15:06
dd091b3 to
2ba0d70
Compare
jmazur
reviewed
Aug 18, 2026
Comment on lines
+17
to
+21
| as_packaged = NutritionFact. | ||
| build_from_array(data[:nutrition_facts][:as_packaged]) | ||
| as_cooked = NutritionFact. | ||
| build_from_array(data[:nutrition_facts]. | ||
| fetch(:as_cooked, [])) |
Collaborator
There was a problem hiding this comment.
i guess as packaged always exists and as cooked only exists sometimes?
Collaborator
Author
There was a problem hiding this comment.
Yes, exactly that. as_cooked is optionally returned, so using fetch to guard against that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 2 of the api is now available, and introduces the Product resource. We'd like to expose this via the gem, allowing our clients to consume this new resource. The Product resource will be retrieved via ID using a different api, version 2. This new API utilizes a basic authentication scheme. Since this is the first resource to be consumed via the v2 API this PR not only introduces Products, it also adds all the plumbing required to interact with the new api version.
This change addresses the need by: